Hi Hans, On Sun, Nov 03, 2019 at 12:23:32PM +0100, Hans Verkuil wrote: > There were still two returns in smiapp_start_streaming() that should > have been a goto to ensure mutex_unload was called before returning. > > This fixes this smatch warning: > > drivers/media/i2c/smiapp/smiapp-core.c:1483 smiapp_start_streaming() warn: inconsistent returns 'mutex:&sensor->mutex'. > > Signed-off-by: Hans Verkuil <hverkuil-cisco@xxxxxxxxx> > Cc: Sakari Ailus <sakari.ailus@xxxxxxxxxxxxxxx> Thanks for the patch. Dan Carpenter submitted one with equivalent content, and it's in my pull request to Mauro: <URL:https://patchwork.linuxtv.org/patch/59698/> -- Regards, Sakari Ailus sakari.ailus@xxxxxxxxxxxxxxx
