Re: [PATCH 4/8] rc/ite-cir: fix smatch warning

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, Nov 03, 2019 at 12:23:34PM +0100, Hans Verkuil wrote:
> Use sizeof instead of ARRAY_SIZE to fix this smatch warning:
> 
> drivers/media/rc/ite-cir.c:385 ite_tx_ir() warn: calling memset(x, y, ARRAY_SIZE());
> 
> Signed-off-by: Hans Verkuil <hverkuil-cisco@xxxxxxxxx>
> Cc: Sean Young <sean@xxxxxxxx>

Acked-by: Sean Young <sean@xxxxxxxx>

Thanks,
Sean

> ---
>  drivers/media/rc/ite-cir.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/media/rc/ite-cir.c b/drivers/media/rc/ite-cir.c
> index 3ab6cec0dc3b..07667c04c1d2 100644
> --- a/drivers/media/rc/ite-cir.c
> +++ b/drivers/media/rc/ite-cir.c
> @@ -382,7 +382,7 @@ static int ite_tx_ir(struct rc_dev *rcdev, unsigned *txbuf, unsigned n)
>  	ite_dbg("%s called", __func__);
>  
>  	/* clear the array just in case */
> -	memset(last_sent, 0, ARRAY_SIZE(last_sent));
> +	memset(last_sent, 0, sizeof(last_sent));
>  
>  	spin_lock_irqsave(&dev->lock, flags);
>  
> -- 
> 2.23.0



[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux