Hi Manivannan,
On Fri, Nov 01, 2019 at 08:22:46PM +0530, Manivannan Sadhasivam wrote:
...
> > +static int imx296_probe(struct i2c_client *client,
> > + const struct i2c_device_id *did)
> > +{
> > + struct i2c_adapter *adapter = to_i2c_adapter(client->dev.parent);
> > + unsigned long clk_rate;
> > + struct imx296 *imx;
>
> imx sounds like a generic name since it may imply to some NXP SoC family too,
> so I'd suggest using imx296.
Here, "imx" is being used in the scope of this driver only. I see no reason
to change it; it's obviously not related to i.MX SoCs.
But I think it could be called e.g. "sensor" as well for that's what it is.
--
Regards,
Sakari Ailus
