Hi Mani, On Thu, Oct 31, 2019 at 06:53:52PM +0530, Manivannan Sadhasivam wrote: > On Thu, Oct 31, 2019 at 03:16:44PM +0200, Laurent Pinchart wrote: > > On Wed, Oct 30, 2019 at 03:19:00PM +0530, Manivannan Sadhasivam wrote: > > > Hello, > > > > > > This patchset adds support for IMX296 CMOS image sensor from Sony. > > > Sensor can be programmed through I2C and 4-wire interface but the > > > current driver only supports I2C interface. The sensor is > > > capable of outputting frames in CSI2 format (1 Lane). In the case > > > of sensor resolution, driver only supports 1440x1088 at 30 FPS. > > > > > > The driver has been validated using Framos IMX296 module interfaced to > > > 96Boards Dragonboard410c. > > > > I've just been made aware of your work. I also worked on an IMX296 > > sensor driver in parallel, which I will post to the list. My driver > > doesn't hardcode the resolution but computes register values at runtime, > > so I wonder if it could be a better option. I'll post it now. > > I'm fine with it. The reason the driver is simple in the first place is, that's > how my usual workflow is. Start small and build it big ;-) > > Anyway, I'm happy if your driver gets in. My driver sometimes has trouble finding the sensor at probe time, so I'll study and try your code too. It could be a problem specific to my platform (I'm testing on a custom i.MX7 board). > > > Changes in v4: > > > > > > * Fixed issues related to gain settings and few misc cleanups in driver > > > * Documented port node and removed maxItems, default prop from dt binding > > > as per the review > > > > > > Changes in v3: > > > > > > * Fixed the reference to video-interfaces.txt in binding. > > > > > > Changes in v2: > > > > > > * Switched to YAML binding > > > > > > Manivannan Sadhasivam (2): > > > dt-bindings: media: i2c: Add IMX296 CMOS sensor binding > > > media: i2c: Add IMX296 CMOS image sensor driver > > > > > > .../devicetree/bindings/media/i2c/imx296.yaml | 94 +++ > > > MAINTAINERS | 8 + > > > drivers/media/i2c/Kconfig | 11 + > > > drivers/media/i2c/Makefile | 1 + > > > drivers/media/i2c/imx296.c | 715 ++++++++++++++++++ > > > 5 files changed, 829 insertions(+) > > > create mode 100644 Documentation/devicetree/bindings/media/i2c/imx296.yaml > > > create mode 100644 drivers/media/i2c/imx296.c -- Regards, Laurent Pinchart
