Hi Shawn, On Thu, Oct 31, 2019 at 09:53:56AM +0000, Tu, ShawnX wrote: > Hi Sakari, > > The patch v3 modified & fixed Kconfig conflict issue base latest codebase. Please avoid top posting. The Kconfig chunk appears to be the same as in v2. > > Thanks, > Shawn > -----Original Message----- > From: Sakari Ailus [mailto:sakari.ailus@xxxxxxxxxxxxxxx] > Sent: Thursday, October 31, 2019 5:36 PM > To: Tu, ShawnX <shawnx.tu@xxxxxxxxx> > Cc: linux-media@xxxxxxxxxxxxxxx; Yeh, Andy <andy.yeh@xxxxxxxxx> > Subject: Re: [PATCH v3] hi556: Add support for Hi-556 sensor > > Hi Shawn, > > On Thu, Oct 31, 2019 at 05:18:55PM +0800, Shawnx Tu wrote: > > diff --git a/drivers/media/i2c/Kconfig b/drivers/media/i2c/Kconfig > > index 7eee181..eab4b78 100644 > > --- a/drivers/media/i2c/Kconfig > > +++ b/drivers/media/i2c/Kconfig > > @@ -566,6 +566,19 @@ config VIDEO_APTINA_PLL config VIDEO_SMIAPP_PLL > > tristate > > > > +config VIDEO_HI556 > > + tristate "Hynix Hi-556 sensor support" > > + depends on I2C && VIDEO_V4L2 && VIDEO_V4L2_SUBDEV_API > > + depends on MEDIA_CAMERA_SUPPORT > > + depends on MEDIA_CONTROLLER > > + select V4L2_FWNODE > > + help > > + This is a Video4Linux2 sensor driver for the Hynix > > + Hi-556 camera. > > + > > + To compile this driver as a module, choose M here: the > > + module will be called hi556. > > + > > Can you fix the Kconfig issue kbuild bot found? > > -- > Sakari Ailus -- Sakari Ailus