Hi Geert,
On 25/10/2019 09:46, Geert Uytterhoeven wrote:
> Hi Kieran,
>
> On Thu, Oct 24, 2019 at 6:08 PM Kieran Bingham
> <kieran.bingham+renesas@xxxxxxxxxxxxxxxx> wrote:
>> On 24/10/2019 14:09, Geert Uytterhoeven wrote:
>>> The official name is "R-Car M3-N", not "R-Car M3N".
>>>
>>> Fixes: 4e8c120de9268fc2 ("media: fdp1: Support M3N and E3 platforms")
>>> Signed-off-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
>>> ---
>>> drivers/media/platform/rcar_fdp1.c | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/media/platform/rcar_fdp1.c b/drivers/media/platform/rcar_fdp1.c
>>> index cb93a13e1777a53e..97bed45360f088d0 100644
>>> --- a/drivers/media/platform/rcar_fdp1.c
>>> +++ b/drivers/media/platform/rcar_fdp1.c
>>> @@ -2369,7 +2369,7 @@ static int fdp1_probe(struct platform_device *pdev)
>>> dprintk(fdp1, "FDP1 Version R-Car H3\n");
>>> break;
>>> case FD1_IP_M3N:
>>
>> Should the FD1_IP_M3N naming also be updated accordingly?
>> I guess that's not so important.
>>
>> Either way, up to you.
>
> Na, you can't use hyphens in preprocessor definitions ;-)> FD1_IP_M3N is consistent with FD1_IP_M3W, and not user-visible.
Hahaha - of course :-D , I meant with M3_N but as we already have IP_M3W
I think we're fine.
>> Reviewed-by: Kieran Bingham <kieran.bingham+renesas@xxxxxxxxxxxxxxxx>
>
> Thanks!
No worries
--
KB
>
> Gr{oetje,eeting}s,
>
> Geert
>
