Hi Philipp,
Thank you for the patch.
On 10/24/19 3:35 PM, Philipp Zabel wrote:
> The number of components are only set, and never used.
>
> Signed-off-by: Philipp Zabel <p.zabel@xxxxxxxxxxxxxx>
> ---
> drivers/media/platform/s5p-jpeg/jpeg-core.c | 1 -
> drivers/media/platform/s5p-jpeg/jpeg-core.h | 2 --
> 2 files changed, 3 deletions(-)
>
> diff --git a/drivers/media/platform/s5p-jpeg/jpeg-core.c b/drivers/media/platform/s5p-jpeg/jpeg-core.c
> index 8dbbd5f2a40a..ac2162235cef 100644
> --- a/drivers/media/platform/s5p-jpeg/jpeg-core.c
> +++ b/drivers/media/platform/s5p-jpeg/jpeg-core.c
> @@ -1236,7 +1236,6 @@ static bool s5p_jpeg_parse_hdr(struct s5p_jpeg_q_data *result,
> }
> result->sof = sof;
> result->sof_len = sof_len;
> - result->components = components;
>
> return true;
> }
> diff --git a/drivers/media/platform/s5p-jpeg/jpeg-core.h b/drivers/media/platform/s5p-jpeg/jpeg-core.h
> index 3bc52f83f5bc..4407fe775afa 100644
> --- a/drivers/media/platform/s5p-jpeg/jpeg-core.h
> +++ b/drivers/media/platform/s5p-jpeg/jpeg-core.h
> @@ -190,7 +190,6 @@ struct s5p_jpeg_marker {
> * @dqt: DQT markers' positions relative to the buffer beginning
> * @sof: SOF0 marker's position relative to the buffer beginning
> * @sof_len: SOF0 marker's payload length (without length field itself)
> - * @components: number of image components
> * @size: image buffer size in bytes
> */
> struct s5p_jpeg_q_data {
> @@ -202,7 +201,6 @@ struct s5p_jpeg_q_data {
> struct s5p_jpeg_marker dqt;
> u32 sof;
> u32 sof_len;
> - u32 components;
> u32 size;
> };
>
>
Reviewed-by: Jacek Anaszewski <jacek.anaszewski@xxxxxxxxx>
--
Best regards,
Jacek Anaszewski
