Hi Jacopo, On Mon, Oct 07, 2019 at 06:29:02PM +0200, Jacopo Mondi wrote: > Hello, fourth iteration following: > > "media: v4l2-ctrls: Add camera sensor location" > https://patchwork.kernel.org/project/linux-media/list/?series=160901 > "[v2,00/10] media: Report camera sensor properties > https://patchwork.kernel.org/cover/11116443/ > "[PATCH v3 00/11] media: Report camera sensor properties" > https://patchwork.kernel.org/project/linux-media/list/?series=173571 > > I here included Hans' comments. Most notable changes > > v3 -> v4: > - Minor reword in documentation of location and rotation properties > - Fix V4L2_CID_CAMERA_SENSOR_ROTATION control documentation > - Renamed helper in v4l2_ctrl_new_fwnode_properties() > v2->v3: > - Expand 'rotation' property description > - s/device/system in properties description to make them applicable to > cameras and flash LEDs > - Expand the rotation control description > - Split helper to parse properties and helper to register properties > - Drop the example coreboot patch that add properties to the Soraka device > ACPI tables > > I know there are still doubts the two properties might well apply to > modern devices with movable cameras, but I still think they cover 99% of devices > out there at the moment. Could you cc this on the next time (or bounce now) this to the devicetree list, please? -- Sakari Ailus sakari.ailus@xxxxxxxxxxxxxxx