On Wed, Oct 16, 2019 at 6:14 PM Russell King - ARM Linux admin <linux@xxxxxxxxxxxxxxx> wrote: > > On Wed, Oct 16, 2019 at 03:39:15PM +0200, Hans Verkuil wrote: > > From: Dariusz Marcinkiewicz <darekm@xxxxxxxxxx> > > > > Use the new cec_notifier_conn_(un)register() functions to > > (un)register the notifier for the HDMI connector. > > > > Signed-off-by: Dariusz Marcinkiewicz <darekm@xxxxxxxxxx> > > Signed-off-by: Hans Verkuil <hverkuil-cisco@xxxxxxxxx> > > Please explain in detail what this mutex actually achieves. > .... > So, all in all, I don't see what this lock is doing, and I think it > should be removed. > > If it's necessary for a future change (which may or may not be merged) > then the lock should be part of that future change, because the change > proposed by this patch certainly does not need it. > Yes, with the change being split into 2 patches like that, the mutex is not needed here. Thank you.