[linux-review:UPDATE-20191005-052600/Mauro-Carvalho-Chehab/Re-PATCH-si2157-Add-support-for-Logilink-VG0022A/20191003-040233 1/1] drivers/media//usb/dvb-usb-v2/af9035.c:1273:16: error: 'struct si2168_config' has no member named 'dont_load_firmware'

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



tree:   https://github.com/0day-ci/linux/commits/UPDATE-20191005-052600/Mauro-Carvalho-Chehab/Re-PATCH-si2157-Add-support-for-Logilink-VG0022A/20191003-040233
head:   78db06b57e0c9d156d5487ffcab15aaee479ffb4
commit: 78db06b57e0c9d156d5487ffcab15aaee479ffb4 [1/1] media: af9035: add support for Logilink VG0022A
config: xtensa-allyesconfig (attached as .config)
compiler: xtensa-linux-gcc (GCC) 7.4.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        git checkout 78db06b57e0c9d156d5487ffcab15aaee479ffb4
        # save the attached .config to linux build tree
        GCC_VERSION=7.4.0 make.cross ARCH=xtensa 

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@xxxxxxxxx>

All errors (new ones prefixed by >>):

   drivers/media//usb/dvb-usb-v2/af9035.c: In function 'it930x_frontend_attach':
>> drivers/media//usb/dvb-usb-v2/af9035.c:1273:16: error: 'struct si2168_config' has no member named 'dont_load_firmware'
      si2168_config.dont_load_firmware = true;
                   ^

vim +1273 drivers/media//usb/dvb-usb-v2/af9035.c

  1199	
  1200	static int it930x_frontend_attach(struct dvb_usb_adapter *adap)
  1201	{
  1202		struct state *state = adap_to_priv(adap);
  1203		struct dvb_usb_device *d = adap_to_d(adap);
  1204		struct usb_interface *intf = d->intf;
  1205		int ret;
  1206		struct si2168_config si2168_config;
  1207		struct i2c_adapter *adapter;
  1208	
  1209		dev_dbg(&intf->dev, "adap->id=%d\n", adap->id);
  1210	
  1211		/* I2C master bus 2 clock speed 300k */
  1212		ret = af9035_wr_reg(d, 0x00f6a7, 0x07);
  1213		if (ret < 0)
  1214			goto err;
  1215	
  1216		/* I2C master bus 1,3 clock speed 300k */
  1217		ret = af9035_wr_reg(d, 0x00f103, 0x07);
  1218		if (ret < 0)
  1219			goto err;
  1220	
  1221		/* set gpio11 low */
  1222		ret = af9035_wr_reg_mask(d, 0xd8d4, 0x01, 0x01);
  1223		if (ret < 0)
  1224			goto err;
  1225	
  1226		ret = af9035_wr_reg_mask(d, 0xd8d5, 0x01, 0x01);
  1227		if (ret < 0)
  1228			goto err;
  1229	
  1230		ret = af9035_wr_reg_mask(d, 0xd8d3, 0x01, 0x01);
  1231		if (ret < 0)
  1232			goto err;
  1233	
  1234		/* Tuner enable using gpiot2_en, gpiot2_on and gpiot2_o (reset) */
  1235		ret = af9035_wr_reg_mask(d, 0xd8b8, 0x01, 0x01);
  1236		if (ret < 0)
  1237			goto err;
  1238	
  1239		ret = af9035_wr_reg_mask(d, 0xd8b9, 0x01, 0x01);
  1240		if (ret < 0)
  1241			goto err;
  1242	
  1243		ret = af9035_wr_reg_mask(d, 0xd8b7, 0x00, 0x01);
  1244		if (ret < 0)
  1245			goto err;
  1246	
  1247		msleep(200);
  1248	
  1249		ret = af9035_wr_reg_mask(d, 0xd8b7, 0x01, 0x01);
  1250		if (ret < 0)
  1251			goto err;
  1252	
  1253		memset(&si2168_config, 0, sizeof(si2168_config));
  1254		si2168_config.i2c_adapter = &adapter;
  1255		si2168_config.fe = &adap->fe[0];
  1256		si2168_config.ts_mode = SI2168_TS_SERIAL;
  1257	
  1258		/*
  1259		 * HACK: The Logilink VG0022A has a bug: when the si2168
  1260		 * firmware that came with the device is replaced by a new
  1261		 * one, the I2C transfers to the tuner will return just 0xff.
  1262		 *
  1263		 * Probably, the vendor firmware has some patch specifically
  1264		 * designed for this device. So, we can't replace by the
  1265		 * generic firmware. The right solution would be to extract
  1266		 * the si2168 firmware from the original driver and ask the
  1267		 * driver to load the specifically designed firmware, but,
  1268		 * while we don't have that, the next best solution is to just
  1269		 * keep the original firmware at the device.
  1270		 */
  1271		if (le16_to_cpu(d->udev->descriptor.idVendor) == USB_VID_DEXATEK &&
  1272		    le16_to_cpu(d->udev->descriptor.idProduct) == 0x0100)
> 1273			si2168_config.dont_load_firmware = true;
  1274	
  1275		state->af9033_config[adap->id].fe = &adap->fe[0];
  1276		state->af9033_config[adap->id].ops = &state->ops;
  1277		ret = af9035_add_i2c_dev(d, "si2168",
  1278					 it930x_addresses_table[state->it930x_addresses].frontend_i2c_addr,
  1279					 &si2168_config, &d->i2c_adap);
  1280		if (ret)
  1281			goto err;
  1282	
  1283		if (adap->fe[0] == NULL) {
  1284			ret = -ENODEV;
  1285			goto err;
  1286		}
  1287		state->i2c_adapter_demod = adapter;
  1288	
  1289		return 0;
  1290	
  1291	err:
  1292		dev_dbg(&intf->dev, "failed=%d\n", ret);
  1293	
  1294		return ret;
  1295	}
  1296	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Attachment: .config.gz
Description: application/gzip


[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux