Re: [PATCH v2 1/5] media: vimc: initialize vim entity pointers to NULL

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On 10/3/19 7:44 AM, Dafna Hirschfeld wrote:
> since NULL value for vimc entity pointer indicates
> that entity creation failed and this is tested, the
> pointers should be initialized to NULL.
> 
> Signed-off-by: Dafna Hirschfeld <dafna.hirschfeld@xxxxxxxxxxxxx>

Acked-by: Helen Koike <helen.koike@xxxxxxxxxxxxx>

> ---
>  drivers/media/platform/vimc/vimc-core.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/media/platform/vimc/vimc-core.c b/drivers/media/platform/vimc/vimc-core.c
> index 6e3e5c91ae39..b8add4087652 100644
> --- a/drivers/media/platform/vimc/vimc-core.c
> +++ b/drivers/media/platform/vimc/vimc-core.c
> @@ -199,9 +199,8 @@ static int vimc_register_devices(struct vimc_device *vimc)
>  	}
>  
>  	/* allocate ent_devs */
> -	vimc->ent_devs = kmalloc_array(vimc->pipe_cfg->num_ents,
> -				       sizeof(*vimc->ent_devs),
> -				       GFP_KERNEL);
> +	vimc->ent_devs = kcalloc(vimc->pipe_cfg->num_ents,
> +				 sizeof(*vimc->ent_devs), GFP_KERNEL);
>  	if (!vimc->ent_devs)
>  		goto err_v4l2_unregister;
>  
> 



[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux