Em Fri, 27 Sep 2019 16:27:00 +0200 Hans Verkuil <hverkuil-cisco@xxxxxxxxx> escreveu: > Various fixes for am437x-vpfe. > > One special note: the last three patches adds new macros to be able to > print a V4L2 fourcc in a standard way, both for kernel and userspace, > and uses them in v4l2-ioctl.c and am437x. > > If you have concerns about this and do not want to merge those patches > without discussing this some more, then please just drop these last three > patches. I looked at the patch with introduced the fourcc. While I like the idea, IMHO, the implementation should be improved. Instead of adding obscure subsystem-specific magic strings to be added at printk() lines, it should, instead, add a new macro to be handled by printk, properly documenting it at: Documentation/core-api/printk-formats.rst There are other subsystems with macros there, like the network subsystem. So, I suspect that it shouldn't be hard to add something like "%pCC" with would properly print the fourcc. So, I'm dropping the last 3 patches on this series applying the remaining ones. Regards, Mauro > > Regards, > > Hans > > The following changes since commit 6f51fdfd8229d5358c2d6e272cf73478866e8ddc: > > media: videobuf-core.c: poll_wait needs a non-NULL buf pointer (2019-09-05 06:26:57 -0300) > > are available in the Git repository at: > > git://linuxtv.org/hverkuil/media_tree.git tags/br-v5.5c2 > > for you to fetch changes up to 743d13880c0749ca61a40ec4c57ebeb60d06f9c6: > > media: am437x-vpfe: Remove print_fourcc helper (2019-09-27 16:24:49 +0200) > > ---------------------------------------------------------------- > Tag branch > > ---------------------------------------------------------------- > Benoit Parrot (12): > media: am437x-vpfe: Fix missing first line > media: am437x-vpfe: Rework ISR routine for clarity > media: am437x-vpfe: Wait for end of frame before tear-down > media: am437x-vpfe: fix start streaming error path > media: am437x-vpfe: Streamlined vb2 buffer cleanup > media: am437x-vpfe: Setting STD to current value is not an error > media: am437x-vpfe: Use a per instance format array instead of a static one > media: am437x-vpfe: fix function trace debug log > media: am437x-vpfe: TRY_FMT ioctl is not really trying anything > media: am437x-vpfe: Remove per bus width static data > media: am437x-vpfe: Switch to SPDX Licensing > media: am437x-vpfe: Remove print_fourcc helper > > Dave Gerlach (1): > media: am437x-vpfe: Fix suspend path to always handle pinctrl config > > Hans Verkuil (1): > v4l2-ioctl.c: use new v4l2_fourcc_conv/args macros > > Sakari Ailus (1): > v4l: Add macros for printing V4L fourcc values > > Documentation/media/videodev2.h.rst.exceptions | 2 + > drivers/media/platform/am437x/am437x-vpfe.c | 880 +++++++++++++++++++++++++---------------------------------- > drivers/media/platform/am437x/am437x-vpfe.h | 43 ++- > drivers/media/platform/am437x/am437x-vpfe_regs.h | 10 +- > drivers/media/v4l2-core/v4l2-ioctl.c | 58 ++-- > include/uapi/linux/videodev2.h | 27 ++ > 6 files changed, 453 insertions(+), 567 deletions(-) Thanks, Mauro
