On Sun, Sep 22, 2019 at 2:08 PM Qiang Yu <yuq825@xxxxxxxxx> wrote:
>
> This causes kernel crash when testing lima driver.
>
> Cc: Christian König <christian.koenig@xxxxxxx>
> Fixes: b8c036dfc66f ("dma-buf: simplify reservation_object_get_fences_rcu a bit")
> Signed-off-by: Qiang Yu <yuq825@xxxxxxxxx>
Selftest for this would be lovely, now that the basic infrastructure
is in place ...
-Daniel
> ---
> drivers/dma-buf/dma-resv.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/dma-buf/dma-resv.c b/drivers/dma-buf/dma-resv.c
> index 42a8f3f11681..709002515550 100644
> --- a/drivers/dma-buf/dma-resv.c
> +++ b/drivers/dma-buf/dma-resv.c
> @@ -471,7 +471,7 @@ int dma_resv_get_fences_rcu(struct dma_resv *obj,
> if (pfence_excl)
> *pfence_excl = fence_excl;
> else if (fence_excl)
> - shared[++shared_count] = fence_excl;
> + shared[shared_count++] = fence_excl;
>
> if (!shared_count) {
> kfree(shared);
> --
> 2.17.1
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@xxxxxxxxxxxxxxxxxxxxx
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
