Re: [PATCH 2/2] media: uapi: h264: clarify pic_order_cnt_bit_size field

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 9/5/19 3:12 PM, Philipp Zabel wrote:
> Since pic_order_cnt_bit_size is not a syntax element itself, explicitly
> state that it is the total size in bits of the pic_order_cnt_lsb,
> delta_pic_order_cnt_bottom, delta_pic_order_cnt[0], and
> delta_pic_order_cnt[1] syntax elements contained in the slice.
> 
> Signed-off-by: Philipp Zabel <p.zabel@xxxxxxxxxxxxxx>
> ---
>  Documentation/media/uapi/v4l/ext-ctrls-codec.rst | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/media/uapi/v4l/ext-ctrls-codec.rst b/Documentation/media/uapi/v4l/ext-ctrls-codec.rst
> index c281bc7ed1b3..08b49b2bbfa8 100644
> --- a/Documentation/media/uapi/v4l/ext-ctrls-codec.rst
> +++ b/Documentation/media/uapi/v4l/ext-ctrls-codec.rst
> @@ -1799,7 +1799,8 @@ enum v4l2_mpeg_video_h264_hierarchical_coding_type -
>        - Size in bits of the dec_ref_pic_marking() syntax element.
>      * - __u32
>        - ``pic_order_cnt_bit_size``
> -      -
> +      - Size in bits of the pic_order_cnt_lsb, delta_pic_order_cnt_bottom,
> +        delta_pic_order_cnt[0], and delta_pic_order_cnt[1] syntax elements.

It's a little bit ambiguous: this field contains the size in bits of all these
fields combined, right? Not the size in bits of each field separately.

I.e. if these fields are all 8 bits, then pic_order_cnt_bit_size is 4*8 and
not just 8.

I think this should be rephrased.

Regards,

	Hans

>      * - __u8
>        - ``cabac_init_idc``
>        -
> 




[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux