Hi Ricardo, On Fri, Sep 20, 2019 at 03:51:34PM +0200, Ricardo Ribalda Delgado wrote: > From: Ricardo Ribalda Delgado <ribalda@xxxxxxxxxx> > > A struct v4l2_area containing the width and the height of a rectangular > area. > > Reviewed-by: Philipp Zabel <p.zabel@xxxxxxxxxxxxxx> > Signed-off-by: Ricardo Ribalda Delgado <ribalda@xxxxxxxxxx> > --- > Documentation/media/uapi/v4l/vidioc-queryctrl.rst | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/Documentation/media/uapi/v4l/vidioc-queryctrl.rst b/Documentation/media/uapi/v4l/vidioc-queryctrl.rst > index a3d56ffbf4cc..33aff21b7d11 100644 > --- a/Documentation/media/uapi/v4l/vidioc-queryctrl.rst > +++ b/Documentation/media/uapi/v4l/vidioc-queryctrl.rst > @@ -443,6 +443,12 @@ See also the examples in :ref:`control`. > - n/a > - A struct :c:type:`v4l2_ctrl_mpeg2_quantization`, containing MPEG-2 > quantization matrices for stateless video decoders. > + * - ``V4L2_CTRL_TYPE_AREA`` > + - n/a > + - n/a > + - n/a > + - A struct :c:type:`v4l2_area`, containing the width and the height > + of a rectangular area. Units depend on the use case. I recall Hans too was in favour of having min, max and step defined (and applied to both width and height). Really a minor issue from my side, feel free to keep it the way it is Reviewed-by: Jacopo Mondi <jacopo@xxxxxxxxxx> Thanks j > * - ``V4L2_CTRL_TYPE_H264_SPS`` > - n/a > - n/a > -- > 2.23.0 >
Attachment:
signature.asc
Description: PGP signature
