On 9/16/19 2:07 PM, Sakari Ailus wrote: > On Mon, Sep 16, 2019 at 12:04:32PM +0200, Hans Verkuil wrote: >> From: Sakari Ailus <sakari.ailus@xxxxxxxxxxxxxxx> >> >> Add two macros that facilitate printing V4L fourcc values with printf >> family of functions. v4l2_fourcc_conv provides the printf conversion >> specifier for printing formats and v4l2_fourcc_args provides the actual >> arguments for that conversion specifier. >> >> These macros are useful in both user and kernel code whenever you want >> to report a pixelformat, therefore put them into videodev2.h. >> >> Signed-off-by: Sakari Ailus <sakari.ailus@xxxxxxxxxxxxxxx> >> [hverkuil-cisco@xxxxxxxxx: rename v4l2_fourcc_to_conv to v4l2_fourcc_args] >> [hverkuil-cisco@xxxxxxxxx: add () around ? : expression] >> [hverkuil-cisco@xxxxxxxxx: add comment about fourcc reuse] >> [hverkuil-cisco@xxxxxxxxx: update Documentation/media/videodev2.h.rst.exceptions] > > Were you going to add your SoB when merging the patch to your tree? Or is > it just missing here? My SoB will be added when I merge it. It's 90% your work, so I don't feel I have any authorship rights for this patch. > > Feel free to add: > > Acked-by: Sakari Ailus <sakari.ailus@xxxxxxxxxxxxxxx> > Regards, Hans