On 9/15/19 8:52 PM, Shuah Khan wrote: > On 9/15/19 1:25 PM, Helen Koike wrote: >> Hi Shuah, >> >> On 9/6/19 11:42 PM, Shuah Khan wrote: >>> Move duplicated IS_SRC and IS_SINK dfines to common header. Rename >>> them to VIMC_IS_SRC and VIM_IS_SINK. >>> >>> Signed-off-by: Shuah Khan <skhan@xxxxxxxxxxxxxxxxxxx> >>> --- >>> drivers/media/platform/vimc/vimc-common.h | 4 ++++ >>> drivers/media/platform/vimc/vimc-debayer.c | 11 ++++------- >>> drivers/media/platform/vimc/vimc-scaler.c | 8 +++----- >>> 3 files changed, 11 insertions(+), 12 deletions(-) >>> >>> diff --git a/drivers/media/platform/vimc/vimc-common.h b/drivers/media/platform/vimc/vimc-common.h >>> index 87ee84f78322..236412ad7548 100644 >>> --- a/drivers/media/platform/vimc/vimc-common.h >>> +++ b/drivers/media/platform/vimc/vimc-common.h >>> @@ -27,6 +27,10 @@ >>> #define VIMC_FRAME_INDEX(lin, col, width, bpp) ((lin * width + col) * bpp) >>> +/* Source and sink pad checks */ >>> +#define VIMC_IS_SRC(pad) (pad) >>> +#define VIMC_IS_SINK(pad) (!(pad)) >> >> This is true now, but it might not be true in the future. >> In the output video device (that was sent by André but not yet upstream) for instance, only have a single >> source pad (which I suppose the index will be 0), and this macro won't be true. >> > >> Maybe we could check pad flags in sd->entity->pads[index].flags ? >> > > I think this change should be done in André's patch? Could be yes, making it generic since the start would be nice, but I don't mind updating this latter when needed. Then: Acked-by: Helen Koike <helen.koike@xxxxxxxxxxxxx> > > thanks, > -- Shuah Thanks Helen
