Re: [PATCH -next 2/2] media: aspeed: set hsync and vsync polarities to normal before starting mode detection

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 9/12/2019 5:18 PM, Andrew Jeffery wrote:


On Fri, 13 Sep 2019, at 02:36, Jae Hyun Yoo wrote:
On 9/11/2019 10:39 PM, Andrew Jeffery wrote:


On Wed, 11 Sep 2019, at 04:37, Jae Hyun Yoo wrote:
Sometimes it detects a weird resolution such as 1024x287 when the
actual resolution is 1024x768. To resolve such an issue, this
commit adds clearing for hsync and vsync polarity register bits
at the beginning of the first mode detection. This is recommended
in the datasheet.

I guess this answers my question on the previous patch's commit
message. Maybe it should be in both?

I think the previous patch is a bug fix and this one is an enhancement
patch. Better splitting them.

I wasn't suggesting squashing the patches, I was suggesting updating
the commit message of the first patch to better justify/explain the
change.

Okay. Will update the commit message of the first patch.

Thanks,
Jae




[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux