On Thu, Sep 12, 2019 at 03:17:54PM +0200, Hans Verkuil wrote: > On 8/19/19 2:47 PM, Sakari Ailus wrote: > > Remove switch fall-through cases in the driver. > > > > Signed-off-by: Sakari Ailus <sakari.ailus@xxxxxxxxxxxxxxx> > > --- > > drivers/media/i2c/smiapp/smiapp-core.c | 11 +++++------ > > 1 file changed, 5 insertions(+), 6 deletions(-) > > > > diff --git a/drivers/media/i2c/smiapp/smiapp-core.c b/drivers/media/i2c/smiapp/smiapp-core.c > > index 76d7d204ec17..61de8cdccc4b 100644 > > --- a/drivers/media/i2c/smiapp/smiapp-core.c > > +++ b/drivers/media/i2c/smiapp/smiapp-core.c > > @@ -1674,13 +1674,12 @@ static void smiapp_propagate(struct v4l2_subdev *subdev, > > sensor->binning_vertical = 1; > > } > > } > > - /* Fall through */ > > - case V4L2_SEL_TGT_COMPOSE: > > This doesn't look right: for this target you now enter the default case. > > You probably want to do: > > break; > case V4L2_SEL_TGT_COMPOSE: > break; Yes; thanks. I've just sent v2. -- Sakari Ailus sakari.ailus@xxxxxxxxxxxxxxx
