Em Fri, 06 Sep 2019 05:20:30 -0700 Joe Perches <joe@xxxxxxxxxxx> escreveu: > On Fri, 2019-09-06 at 08:34 -0300, Mauro Carvalho Chehab wrote: > > I did some changes on it, plus one change at the pedantic mode of > > scripts/spdxcheck.py, and placed the corresponding patches at: > > > > https://git.linuxtv.org/mchehab/experimental.git/log/?h=spdx_pedantic > > Overall seems very nice, thanks. > > Couple nits. > > Some of the scripts and py files move the author > block into a description or add unnecessary blank > comments. These may use some manual fixups. True. I noticed that too. I suspect that fixing this automatically would make the script too complex. Anyway, the point is: who will apply it? Linus? Each maintainer? I can apply it to the media subsystem (after applying the patches I have already doing the same), but I don't intend myself to apply it to the other subsystems. > > what's the "very first line" where a > > SPDX header tag should be on a man page? > > Beats me. > This says man pages are documents, > https://spdx.org/rdf/ontology/spdx-2-0-rev-7/individuals/usageType_document___85292652.html > > Yes. I mean, I suspect that a troff file should have a ".TH" at its first line. So, SPDX header should start at the second line. Thanks, Mauro
