On Thu, Sep 05, 2019 at 11:21:34AM +0300, Sakari Ailus wrote: > On Thu, Sep 05, 2019 at 03:21:42PM +0800, dongchun.zhu@xxxxxxxxxxxx wrote: > > From: Dongchun Zhu <dongchun.zhu@xxxxxxxxxxxx> > > +static const struct i2c_device_id dw9768_id_table[] = { > > + { DW9768_NAME, 0 }, > > + { }, > > Could you drop the I²C ID table? But why? It will allow you to instanciate the device from user space. +Cc: Javier. Javier, is it needed in new code? -- With Best Regards, Andy Shevchenko