Hi! Dne petek, 30. avgust 2019 ob 11:26:24 CEST je Hans Verkuil napisal(a): > Initialize the context on open() with valid capture and output > formats. It is good practice to always have valid formats internally. > > This solves one vb2 warning in the kernel log where the sizeimage > value of the output format was 0 when requesting buffers, which is > not allowed. > > It also simplifies the g_fmt ioctl implementations since they no longer > have to check if a valid format was ever set. > > cedrus_prepare_format() now also validates sizeimage for the output > formats, ensuring userspace can't set it to 0 since that would cause > the same vb2 warning. > > Finally remove the sizeimage == 0 check in cedrus_try_fmt_vid_out() > since cedrus_prepare_format() will now adjust this value. > > Signed-off-by: Hans Verkuil <hverkuil-cisco@xxxxxxxxx> > --- > drivers/staging/media/sunxi/cedrus/cedrus.c | 10 +++++++ > .../staging/media/sunxi/cedrus/cedrus_video.c | 28 ++----------------- > .../staging/media/sunxi/cedrus/cedrus_video.h | 1 + > 3 files changed, 14 insertions(+), 25 deletions(-) Selecting default format needs to be expanded to select default format based on compatible. SoCs with Display Engine 2 and 3 don't know how to display tiled formats directly. But that's out of scope for this series. Reviewed-by: Jernej Skrabec <jernej.skrabec@xxxxxxxx> Best regards, Jernej
