On Mon, Aug 19, 2019 at 01:54:53PM +0200, Marc Gonzalez wrote: > On 15/07/2019 11:50, Marc Gonzalez wrote: > > > Use cmd_init() to fill a struct si2168_cmd command. > > > > Signed-off-by: Marc Gonzalez <marc.w.gonzalez@xxxxxxx> > > --- > > Changes from v1: > > - Use a real function to populate struct si2168_cmd *cmd, and a trivial > > macro wrapping it (macro because sizeof). > > Changes from v2: > > - Fix header mess > > - Add Jonathan's tag > > Changes from v3: > > - Drop Jonathan's tag after rewrite > > - Completely drop macro, and explicitly provide 'wlen' argument > > --- > > drivers/media/dvb-frontends/si2168.c | 152 ++++++++------------------- > > 1 file changed, 44 insertions(+), 108 deletions(-) > > Brad, Sean, Antti, > > I believe this patch is good to go. Is anything still wrong with it? It's been accepted: https://git.linuxtv.org/media_tree.git/commit/?id=619f6fc390909fce3247c3e07e6882b868b645da Thanks, Sean
