On Wed, Aug 14, 2019 at 9:53 PM Paul Kocialkowski <paul.kocialkowski@xxxxxxxxxxx> wrote: > > Hi, > > On Mon 12 Aug 19, 13:05, Hans Verkuil wrote: > > From: Maxime Jourdan <mjourdan@xxxxxxxxxxxx> > > > > Add an enum_fmt format flag to specifically tag coded formats where > > dynamic resolution switching is supported by the device. > > > > This is useful for some codec drivers that can support dynamic > > resolution switching for one or more of their listed coded formats. It > > allows userspace to know whether it should extract the video parameters > > itself, or if it can rely on the device to send V4L2_EVENT_SOURCE_CHANGE > > when such changes are detected. > > Makes sense and looks good to me: > Reviewed-by: Paul Kocialkowski <paul.kocialkowski@xxxxxxxxxxx> > > The docs aren't saying that this only applies to stateful decoders, but I think > it is quite clear that this can't apply to stateless decoders. Even though this can be inferred from reading the specs, I think it would be reasonable to explicitly mention it though. I also wonder, since this flag does not make sense for encoders, maybe we can use more precise vocabulary in the patch description and doc? I.e. s/codec/decoder. With that, Reviewed-by: Alexandre Courbot <acourbot@xxxxxxxxxxxx>
