Hello. On Tue, Aug 13, 2019 at 1:20 PM Russell King - ARM Linux admin <linux@xxxxxxxxxxxxxxx> wrote: > > This also doesn't make sense: tda998x_destroy() is the opposite of > tda998x_create(). However, tda998x_connector_destroy() is the > opposite of tda998x_connector_create(). > > By moving the CEC creation code into tda998x_connector_create(), you > are creating the possibility for the following sequence to mess up > CEC and leak: > > tda998x_create() > tda998x_connector_create() > tda998x_connector_destroy() > tda998x_connector_create() > tda998x_connector_destroy() > tda998x_destroy() > > Anything you create in tda998x_connector_create() must be cleaned up > by tda998x_connector_destroy(). > Thank you. I've just sent out another revision of the patch, where registration and deregistration is symmetric. Please take a look. Best regards.
