Hi Russel,
On Tue, Aug 13, 2019 at 12:38:46PM +0100, Russell King - ARM Linux admin wrote:
> On Tue, Aug 06, 2019 at 06:39:36PM +0530, Manivannan Sadhasivam wrote:
> > +Required Properties:
> > +- compatible: Should be "sony,imx290"
> > +- reg: I2C bus address of the device
> > +- clocks: Reference to the xclk clock.
> > +- clock-names: Should be "xclk".
> > +- clock-frequency: Frequency of the xclk clock.
>
> Driver code:
>
> + ret = of_property_read_u32(dev->of_node, "clock-frequency", &xclk_freq);+ if (ret) {
> + dev_err(dev, "Could not get xclk frequency\n");
> + return ret;
> + }
> +
> + /* external clock must be 37.125 MHz */
> + if (xclk_freq != 37125000) {
> + dev_err(dev, "External clock frequency %u is not supported\n",
> + xclk_freq);
> + return -EINVAL;
> + }
>
> So, only 37125000 is supported - is that not worth mentioning in this
> description? Is this a hard requirement of the sensor? If so, why
> does it need to be mentioned in the DT binding?
>
Actually, sensor supports only 2 clock frequencies: 37.125 MHz and 74.25 MHz.
And the driver currently supports only 37.125, because that's what I can test
with my setup.
So how about below:
clock-frequency: Frequency of the xclk clock in Hz. It should be one of the
following:
- 37125000
- 74250000
Thanks,
Mani
> --
> RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
> FTTC broadband for 0.8mile line in suburbia: sync at 12.1Mbps down 622kbps up
> According to speedtest.net: 11.9Mbps down 500kbps up
