Hi Jernej, On Mon, 2019-06-03 at 13:38 +0200, Maxime Ripard wrote: > Hi, > > On Thu, May 30, 2019 at 11:15:10PM +0200, Jernej Skrabec wrote: > > libvdpau-sunxi always disables engine after each decoded slice. > > Do same in Cedrus driver. > > > > Presumably this also lowers power consumption which is always nice. > > > > Signed-off-by: Jernej Skrabec <jernej.skrabec@xxxxxxxx> > > Is it fixing anything though? > > I indeed saw that cedar did disable it everytime, but I couldn't find > a reason why. > > Also, the power management improvement would need to be measured, it > can even create the opposite situation where the device will draw more > current from being woken up than if it had just remained disabled. > While reviewing this, I'm noticing that cedrus_engine_disable can be marked for static storage (with or without this patch). Regards, Eze
