Stefan Ringel wrote: OK, patch is correct, but you should: - Use the email subject to summarize what the patch does - Add more detailed patch description; - Add your Signed-off-by. In this specific case, you could have: Subject: Fix compilation breakage Signed-off-by: your name <your@email> (this is a really trivial patch - so, you don't need a detailed description) > --- a/drivers/staging/tm6000/tm6000-cards.c > +++ b/drivers/staging/tm6000/tm6000-cards.c > @@ -32,7 +32,7 @@ > #include "tm6000.h" > #include "tm6000-regs.h" > #include "tuner-xc2028.h" > -#include "tuner-xc5000.h" > +#include "xc5000.h" > > #define TM6000_BOARD_UNKNOWN 0 > #define TM5600_BOARD_GENERIC 1 > -- Cheers, Mauro -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html