Hi Hans,
On Wed, Aug 7, 2019 at 1:05 PM Hans Verkuil <hverkuil@xxxxxxxxx> wrote:
> On 8/7/19 12:53 PM, Geert Uytterhoeven wrote:
> > On Wed, Aug 7, 2019 at 11:33 AM Hans Verkuil <hverkuil@xxxxxxxxx> wrote:
> >> On 7/31/19 8:43 PM, Geert Uytterhoeven wrote:
> >>> On Wed, Jul 31, 2019 at 8:36 PM Antti Palosaari <crope@xxxxxx> wrote:
> >>>> On 7/31/19 4:41 PM, Geert Uytterhoeven wrote:
> >>>>> Signed-off-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
> >>>>> ---
> >>>>> drivers/media/usb/tm6000/tm6000-cards.c | 2 +-
> >>>>> 1 file changed, 1 insertion(+), 1 deletion(-)
> >>>>>
> >>>>> diff --git a/drivers/media/usb/tm6000/tm6000-cards.c b/drivers/media/usb/tm6000/tm6000-cards.c
> >>>>> index 23df50aa0a4af6da..9a0ffe678524987c 100644
> >>>>> --- a/drivers/media/usb/tm6000/tm6000-cards.c
> >>>>> +++ b/drivers/media/usb/tm6000/tm6000-cards.c
> >>>>> @@ -1328,7 +1328,7 @@ static int tm6000_usb_probe(struct usb_interface *interface,
> >>>>>
> >>>>> /*
> >>>>> * tm6000_usb_disconnect()
> >>>>> - * called when the device gets diconencted
> >>>>> + * called when the device gets diconnected
> >>>>
> >>>> disconnected ?
> >>>
> >>> Thanks, will fix!
> >>
> >> Can you also add a commit message when you post v2? Currently that's
> >> empty and Linus doesn't like empty commit messages :-)
> >
> > Even if everything to be said is in the one-line summary?
>
> Yes. In fact, checkpatch warns if the commit description is empty.
Quoting the checkpatch.pl maintainer:
"checkpatch is a stupid script and doesn't forbid anything.
It's just a suggestion guide."
https://lore.kernel.org/lkml/20190801124037.11dcac71@xxxxxxxxxxxxxxxxxx/
> In this case, just say 'Fix typo.', that's sufficient.
If that makes you happy...
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
