Hi Hans.
On Tue, Jul 30, 2019 at 2:17 PM Hans Verkuil <hverkuil-cisco@xxxxxxxxx> wrote:
>
> Hi Dariusz,
>
> One comment below:
>
> > int tegra_output_init(struct drm_device *drm, struct tegra_output *output)
> > {
> > + struct cec_connector_info conn_info;
> > int err;
> >
> > if (output->panel) {
> > @@ -212,6 +209,13 @@ int tegra_output_init(struct drm_device *drm, struct tegra_output *output)
> > if (gpio_is_valid(output->hpd_gpio))
> > enable_irq(output->hpd_irq);
> >
> > + cec_fill_conn_info_from_drm(&conn_info, &output->connector);
> > +
>
> This isn't right: tegra_output_init() is called for various output types, but the
> CEC adapter should only be created for an HDMI connector. So there should be
> a check on the connector type before registering a cec notifier.
>
I have just sent out v5 patch series. In there I've updated this patch
to limit the notifier creation only to HDMI connectors. From a cursory
look, though, it seems that so far that the notifier was created
regardless of connector type, so we are changing the existing behavior
here.
Best regards.
