Re: linux-next: Tree for Jul 26 (media/usb/dvb-usb/pctv452e.c)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 7/29/19 10:52 AM, Dominik Kuhlen wrote:
> Hi Randy,
> 
> On Friday 26 July 2019 16:57:50 Randy Dunlap wrote:
>> On 7/25/19 10:23 PM, Stephen Rothwell wrote:
>>> Hi all,
>>>
>>> Changes since 20190725:
>>>
>>
>> on x86_64:
>>
>> In file included from ../drivers/media/usb/dvb-usb/pctv452e.c:16:0:
>> ../drivers/media/usb/dvb-usb/pctv452e.c: In function ‘pctv452e_frontend_attach’:
>> ../drivers/media/dvb-frontends/stb0899_drv.h:139:36: error: weak declaration of ‘stb0899_attach’ being applied to a already existing, static definition
>>  static inline struct dvb_frontend *stb0899_attach(struct stb0899_config *config,
>>                                     ^~~~~~~~~~~~~~
> 
>  cat config-r6623 | grep -i pctv45
> CONFIG_DVB_USB_PCTV452E=y
> 
>  cat config-r6623 | grep -i stb0899
> # CONFIG_DVB_STB0899 is not set
> 
> -> mismatching configuration:
> The pctv452e needs the stb0899 frontend driver to work.
> And the CONFIG_DVB_STB6100 must also be set.

This build error is from a randconfig.  The Kconfig rules for this (any)
driver should not allow build errors to be generated.

For DVB_USB_PCTV452E (and probably most of drivers/media/), there is an
attempt to handle this by the use of MEDIA_SUBDRV_AUTOSELECT (which is
not set/enabled in this particular randconfig).  So I am reporting that
the Kconfig entry for DVB_USB_PCTV452E is not sufficient.
(although I expect that some people won't care)


thanks.
-- 
~Randy



[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux