Em Mon, 15 Jul 2019 18:23:16 -0300 Ezequiel Garcia <ezequiel@xxxxxxxxxxxxx> escreveu: > Many users have been complaining about not being able to find > certain menu options. One such example are camera sensor drivers > (e.g IMX219, OV5645, etc) which are common on embedded platforms > and not always ancillary devices. > > The problem with MEDIA_SUBDRV_AUTOSELECT seems to be related > to the fact that it uses the "visible" kbuild syntax to hide > entire group of drivers. > > This is not obvious and, as explained above, not always desired. > > To fix the problem, drop the "visible" and stop hiding any menu > options. Users skilled enough to configure their kernel are expected > to be skilled enough to know what (not) to configure anyway. > > Signed-off-by: Ezequiel Garcia <ezequiel@xxxxxxxxxxxxx> > --- > drivers/media/dvb-frontends/Kconfig | 1 - > drivers/media/i2c/Kconfig | 1 - > drivers/media/spi/Kconfig | 1 - > drivers/media/tuners/Kconfig | 1 - > 4 files changed, 4 deletions(-) > > diff --git a/drivers/media/dvb-frontends/Kconfig b/drivers/media/dvb-frontends/Kconfig > index dc43749177df..2d1fea3bf546 100644 > --- a/drivers/media/dvb-frontends/Kconfig > +++ b/drivers/media/dvb-frontends/Kconfig > @@ -1,5 +1,4 @@ > menu "Customise DVB Frontends" > - visible if !MEDIA_SUBDRV_AUTOSELECT || COMPILE_TEST || EXPERT > > comment "Multistandard (satellite) frontends" > depends on DVB_CORE > diff --git a/drivers/media/i2c/Kconfig b/drivers/media/i2c/Kconfig > index 79ce9ec6fc1b..475072bb67d6 100644 > --- a/drivers/media/i2c/Kconfig > +++ b/drivers/media/i2c/Kconfig > @@ -23,7 +23,6 @@ config VIDEO_IR_I2C > # > > menu "I2C Encoders, decoders, sensors and other helper chips" > - visible if !MEDIA_SUBDRV_AUTOSELECT || COMPILE_TEST || EXPERT Hmm... Hans picked this patch, but IMO it doesn't make sense for PC consumer people to see the hundreds of extra options that making those menus visible will produce. This was added because in the past we had lots of issues with people desktop/laptop settings with all those things enabled. In any case, if the desktop/laptop user is smart enough to go though it, he can simply disable MEDIA_SUBDRV_AUTOSELECT and manually select what he wants, so I really miss the point of making those stuff always visible. Now, from this patch's comments, it seems that you want this to be visible if CONFIG_EMBEDDED. So, I won't complain if you replace the changes on this patch to: menu "foo" visible if !MEDIA_SUBDRV_AUTOSELECT || !EMBEDDED || COMPILE_TEST || EXPERT In other words, for the normal guy that just wants to build the latest media stuff for his PC camera or TV device to work, he won't need to dig into hundreds of things that won't make any difference if he enables, except for making the Kernel bigger. > > comment "Audio decoders, processors and mixers" > > diff --git a/drivers/media/spi/Kconfig b/drivers/media/spi/Kconfig > index 08386abb9bbc..d94921fe3db5 100644 > --- a/drivers/media/spi/Kconfig > +++ b/drivers/media/spi/Kconfig > @@ -2,7 +2,6 @@ > if VIDEO_V4L2 > > menu "SPI helper chips" > - visible if !MEDIA_SUBDRV_AUTOSELECT || COMPILE_TEST || EXPERT > > config VIDEO_GS1662 > tristate "Gennum Serializers video" > diff --git a/drivers/media/tuners/Kconfig b/drivers/media/tuners/Kconfig > index a7108e575e9b..01212df505ae 100644 > --- a/drivers/media/tuners/Kconfig > +++ b/drivers/media/tuners/Kconfig > @@ -16,7 +16,6 @@ config MEDIA_TUNER > select MEDIA_TUNER_MC44S803 if MEDIA_SUBDRV_AUTOSELECT > > menu "Customize TV tuners" > - visible if !MEDIA_SUBDRV_AUTOSELECT || COMPILE_TEST || EXPERT > depends on MEDIA_ANALOG_TV_SUPPORT || MEDIA_DIGITAL_TV_SUPPORT || MEDIA_RADIO_SUPPORT || MEDIA_SDR_SUPPORT > > config MEDIA_TUNER_SIMPLE Thanks, Mauro
