On Thu, 2019-07-25 at 14:59 +0200, Hans Verkuil wrote: > On 7/24/19 7:16 PM, Ezequiel Garcia wrote: > > This series adds VP8 decoding support on RK3399 SoC. > > > > I'm including a set of commits from Boris' recent H264 series [1]. > > These commits add some helpers that are also useful for RK3399 VP8, > > and at the same time cleanup the driver nicely. > > > > Finally, there's a fix by Francois Buergisser from Chromium team. > > > > VP8 and MPEG-2 tested on RK3399 RockPi and RK3288 Rock2 boards. > > I get this when compiling: > > /home/hans/work/build/media-git/drivers/staging/media/hantro/hantro_g1_vp8_dec.c: In function 'hantro_g1_vp8_dec_run': > /home/hans/work/build/media-git/drivers/staging/media/hantro/hantro_g1_vp8_dec.c:435:26: warning: variable 'vb2_src' set but not used [-Wunused-but- > set-variable] > struct vb2_v4l2_buffer *vb2_src; > ^~~~~~~ > CC drivers/staging/media/omap4iss/iss_csiphy.o > /home/hans/work/build/media-git/drivers/staging/media/hantro/rk3399_vpu_hw_vp8_dec.c: In function 'rk3399_vpu_vp8_dec_run': > /home/hans/work/build/media-git/drivers/staging/media/hantro/rk3399_vpu_hw_vp8_dec.c:515:26: warning: variable 'vb2_src' set but not used [-Wunused- > but-set-variable] > struct vb2_v4l2_buffer *vb2_src; > ^~~~~~~ > > Can you take a look? > Oops, I missed these warnings. I'll fix them and post a new version. Thanks, Eze
