On Wed, Jul 24, 2019 at 11:39:03AM -0700, Joe Perches wrote: > On Wed, 2019-07-24 at 20:35 +0200, Greg Kroah-Hartman wrote: > > On Wed, Jul 24, 2019 at 10:09:44AM -0700, Joe Perches wrote: > > > On Tue, 2019-07-09 at 22:04 -0700, Joe Perches wrote: > > > > Arguments are supposed to be ordered high then low. > > > > > > > > Signed-off-by: Joe Perches <joe@xxxxxxxxxxx> > > > > --- > > > > drivers/staging/media/sunxi/cedrus/cedrus_regs.h | 2 +- > > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > > > diff --git a/drivers/staging/media/sunxi/cedrus/cedrus_regs.h b/drivers/staging/media/sunxi/cedrus/cedrus_regs.h > > > > index 3e9931416e45..ddd29788d685 100644 > > > > --- a/drivers/staging/media/sunxi/cedrus/cedrus_regs.h > > > > +++ b/drivers/staging/media/sunxi/cedrus/cedrus_regs.h > > > > @@ -110,7 +110,7 @@ > > > > #define VE_DEC_MPEG_MBADDR (VE_ENGINE_DEC_MPEG + 0x10) > > > > > > > > #define VE_DEC_MPEG_MBADDR_X(w) (((w) << 8) & GENMASK(15, 8)) > > > > -#define VE_DEC_MPEG_MBADDR_Y(h) (((h) << 0) & GENMASK(0, 7)) > > > > +#define VE_DEC_MPEG_MBADDR_Y(h) (((h) << 0) & GENMASK(7, 0)) > > > > > > > > #define VE_DEC_MPEG_CTRL (VE_ENGINE_DEC_MPEG + 0x14) > > > > > > Greg? ping? > > > > > > > > > > I am not the maintainer of drivers/staging/media, that is Mauro. > > Maybe you want: > --- > diff --git a/MAINTAINERS b/MAINTAINERS > index f7dc5bad396a..2fb95ad6ebef 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -15312,6 +15312,7 @@ T: git git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git > L: devel@xxxxxxxxxxxxxxxxxxxx > S: Supported > F: drivers/staging/ > +X: drivers/staging/media/ > Not really, it's nice to see the patches flow by :)