Re: [PATCH v5] media: v4l: ctrls: Add debug messages

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Ezequiel,

On Sat, Jul 20, 2019 at 08:47:07AM -0300, Ezequiel Garcia wrote:
> Currently, the v4l2 control code is a bit silent on errors.
> Add debug messages on (hopefully) most of the error paths.
> 
> Signed-off-by: Ezequiel Garcia <ezequiel@xxxxxxxxxxxxx>
> ---
> Changes from v3:
> * Add missing parenthesis around macro argument.
> 
> Changes from v3:
> * Fix checkpatch.pl warnings about long lines.
> 
> Changes from v2:
> * Check and noisy-warn if vdev is NULL.

As you require the vdev argument to be non-NULL, you may as well drop the
mdev argument: video device is always specific to a media device, and the
pointer to the media device can be found in vdev->entity.graph_obj.mdev if
MEDIA_CONTROLLER is enabled (AFAIR).

-- 
Kind regards,

Sakari Ailus



[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux