On 2019-07-22, at 11:36:51 +0530, Nishka Dasgupta wrote:
> Typecast as bool the return value of cedrus_find_format in
> cedrus_check_format as the return value of cedrus_check_format is
> always treated like a boolean value.
>
> Signed-off-by: Nishka Dasgupta <nishkadg.linux@xxxxxxxxx>
> ---
> Changes in v2:
> - Add !! to the returned pointer to ensure that the return value is
> always either true or false, and never a non-zero value other than
> true.
>
> drivers/staging/media/sunxi/cedrus/cedrus_video.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/media/sunxi/cedrus/cedrus_video.c b/drivers/staging/media/sunxi/cedrus/cedrus_video.c
> index e2b530b1a956..b731745f21f8 100644
> --- a/drivers/staging/media/sunxi/cedrus/cedrus_video.c
> +++ b/drivers/staging/media/sunxi/cedrus/cedrus_video.c
> @@ -86,7 +86,7 @@ static struct cedrus_format *cedrus_find_format(u32 pixelformat, u32 directions,
> static bool cedrus_check_format(u32 pixelformat, u32 directions,
> unsigned int capabilities)
> {
> - return cedrus_find_format(pixelformat, directions, capabilities);
> + return !!(bool)cedrus_find_format(pixelformat, directions, capabilities);
> }
I think the original was fine. The return value of cedrus_find_format
will be automatically converted to bool before being returned from
cedrus_check_format since that is the return-type of the function, and
the result of converting any non-zero value to bool is 1.
> static void cedrus_prepare_format(struct v4l2_pix_format *pix_fmt)
> --
> 2.19.1
Attachment:
signature.asc
Description: PGP signature
