> On 20 Jul 2019, at 10:25, Maxime Ripard <maxime.ripard@xxxxxxxxxxx> wrote: > > Hi, > > On Thu, Jul 18, 2019 at 12:15:09PM +0100, Jan Kotas wrote: >> /* Put our lanes (clock and data) out of reset */ >> reg = CSI2TX_DPHY_CFG_CLK_RESET | CSI2TX_DPHY_CFG_MODE_LPDT; >> for (i = 0; i < csi2tx->num_lanes; i++) >> - reg |= CSI2TX_DPHY_CFG_LANE_RESET(csi2tx->lanes[i]); >> + reg |= CSI2TX_DPHY_CFG_LANE_RESET(csi2tx->lanes[i] - 1); > > This looks like a separate change? > >> writel(reg, csi2tx->base + CSI2TX_DPHY_CFG_REG); >> >> - udelay(10); >> + csi2tx_dphy_init_finish(csi2tx, reg); >> +} >> >> - /* Enable our (clock and data) lanes */ >> - reg |= CSI2TX_DPHY_CFG_CLK_ENABLE; >> - for (i = 0; i < csi2tx->num_lanes; i++) >> - reg |= CSI2TX_DPHY_CFG_LANE_ENABLE(csi2tx->lanes[i]); > > And you have a similar change here that should be in a separate patch, > with a proper explanation. > > Otherwise, the rest looks good. OK, I’ll create a separate patch with this modification. Jan > Maxime > > -- > Maxime Ripard, Bootlin > Embedded Linux and Kernel engineering > https://bootlin.com
