On Tue, Jul 16, 2019 at 05:11:52AM +0200, JP wrote:
> On 7/15/19 11:21 PM, Sean Young wrote:
> > On Tue, Jul 09, 2019 at 08:39:32PM +0200, Jan Pieter van Woerkom wrote:
> > > From: Jan Pieter van Woerkom <jp@xxxxxxx>
> > >
> > > Adds support for the "Mygica T230C v2" into the "dvbsky" driver.
> > > A small enhancement is also needed in the si2168 demodulator
> > > driver, and a USB device ID in dvb-usb-ids.h .
> > >
> > > This is v3.5 of the proposed patch, based on feedback from Sean
> > > Young and Antti Palosaari.
> > > Tested by patch author on DVB(T/T2/C).
> > > Tested by Frank Rysanek on a T230C v2: can tune into locally
> > > available DVB-T and DVB-T2 muxes, video and audio playback works.
> > > Applies cleanly against Linux 5.2 .
> > >
> > > The T230C v2 hardware needs a mode of the si2168 chip to be
> > > set for which the si2168 driver previously had no support.
> > > This patch uses a specific measure to configure this on the
> > > T230C v2 hardware only - see the flag passed via the ts_mode
> > > attribute and its dependency on USB_PID_MYGICA_T230C2. Other
> > > devices using the si2168 demodulator driver are not affected.
> > >
> > > Signed-off-by: Jan Pieter van Woerkom <jp@xxxxxxx>
> > > Tested-by: Frank Rysanek <Frantisek.Rysanek@xxxxxxx>
> > > ---
> > > diff -ru a/drivers/media/dvb-frontends/si2168.c b/drivers/media/dvb-frontends/si2168.c
> > > --- a/drivers/media/dvb-frontends/si2168.c 2019-07-08 00:41:56.000000000 +0200
> > > +++ b/drivers/media/dvb-frontends/si2168.c 2019-07-09 18:47:59.514873658 +0200
> > > @@ -82,8 +82,18 @@
> > > dev_dbg(&client->dev, "%s acquire: %d\n", __func__, acquire);
> > > + /* set manual value */
> > > + if (dev->ts_mode & SI2168_TS_CLK_MANUAL) {
> > > + memcpy(cmd.args, "\x14\x00\x0d\x10\xe8\x03", 6);
> > > + cmd.wlen = 6;
> > > + cmd.rlen = 4;
> > > + ret = si2168_cmd_execute(client, &cmd);
> > > + if (ret)
> > > + return ret;
> > > + }
> > > /* set TS_MODE property */
> > > - memcpy(cmd.args, "\x14\x00\x01\x10\x10\x00", 6);
> > > + memcpy(cmd.args, "\x14\x00\x01\x10\x00\x00", 6);
> > Here byte at offset 4 is now 0 rather than 0x10.
> >
> > > + cmd.args[4] = dev->ts_mode & (SI2168_TS_CLK_AUTO|SI2168_TS_CLK_MANUAL);
> > The many existing frontends which use the si2168 do have not have ts_mode
> > bit SI2168_TS_CLK_AUTO (0x010) set. So, this changes what is sent for
> > those drivers. Is that intended?
> At least 2 other drivers I tested (T230 in cxusb.c and 1 anysee)
> work with this bit set or clear. My guess was that it would be OK
> to use 0x00. So sort of intended. I couldn't think of a simple
> operation to set one bit and clear the other. I will think again. :-)
Great, thank you! :)
Sean
