Hi Dariusz, On 7/1/19 4:59 PM, Dariusz Marcinkiewicz wrote: > This series updates remaining drivers in DRM to use new CEC notifier API. > > Those complement the "cec: improve notifier support, add > connector info" patch series and also replace 2 following patches from > there: > - [PATCHv8 09/13] dw-hdmi: use cec_notifier_conn_(un)register > - [PATCHv9 12/13] tda998x: use cec_notifier_conn_(un)register > > None of those changes were not tested on a real hardware. I assume you meant 'None of those changes were tested'? I just reviewed this series. Apologies for the delay, I was out for a week and then had to take care of other things. When you post v3, can you include all older drm patches (i.e. tda9950, dw-hdmi-cec, and the drm-dp-cec changes)? That way there is only one patch series that I have to review. Regards, Hans > > Changes since v1: > Those patches delay creation of notifiers until respective > connectors are constructed. It seems that those patches, for a > couple of drivers, by adding the delay, introduce a race between > notifiers' creation and the IRQs handling threads - at least I > don't see anything obvious in there that would explicitly forbid > such races to occur. v2 adds a write barrier to make sure IRQ > threads see the notifier once it is created (replacing the > WRITE_ONCE I put in v1). The best thing to do here, I believe, > would be not to have any synchronization and make sure that an IRQ > only gets enabled after the notifier is created. > > > Dariusz Marcinkiewicz (5): > drm: tda998x: use cec_notifier_conn_(un)register > drm: sti: use cec_notifier_conn_(un)register > drm: tegra: use cec_notifier_conn_(un)register > drm: dw-hdmi: use cec_notifier_conn_(un)register > drm: exynos: exynos_hdmi: use cec_notifier_conn_(un)register > > drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 37 +++++++++++++++-------- > drivers/gpu/drm/exynos/exynos_hdmi.c | 33 ++++++++++++-------- > drivers/gpu/drm/i2c/tda998x_drv.c | 32 ++++++++++++++------ > drivers/gpu/drm/sti/sti_hdmi.c | 20 +++++++----- > drivers/gpu/drm/tegra/output.c | 18 ++++++----- > 5 files changed, 91 insertions(+), 49 deletions(-) >
