On Wed, 2019-07-03 at 17:32 +0900, Tomasz Figa wrote: > Hi Hans, > > On Fri, Jun 28, 2019 at 11:34 PM Hans Verkuil <hverkuil@xxxxxxxxx> wrote: > > > > Hi all, > > > > I hope I Cc-ed everyone with a stake in this issue. > > > > One recurring question is how a stateful encoder fills buffers and how a stateful > > decoder consumes buffers. > > > > The most generic case is that an encoder produces a bitstream and just fills each > > CAPTURE buffer to the brim before continuing with the next buffer. > > > > I don't think there are drivers that do this, I believe that all drivers just > > output a single compressed frame. For interlaced formats I understand it is either > > one compressed field per buffer, or two compressed fields per buffer (this is > > what I heard, I don't know if this is true). > > > > In any case, I don't think this is specified anywhere. Please correct me if I am > > wrong. > > > > The latest stateful codec spec is here: > > > > https://hverkuil.home.xs4all.nl/codec-api/uapi/v4l/dev-mem2mem.html > > > > Assuming what I described above is indeed the case, then I think this should > > be documented. I don't know enough if a flag is needed somewhere to describe > > the behavior for interlaced formats, or can we leave this open and have userspace > > detect this? > > > > From Chromium perspective, we don't have any use case for encoding > interlaced contents, so we'll be okay with whatever the interested > parties decide on. :) > > > > > For decoders it is more complicated. The stateful decoder spec is written with > > the assumption that userspace can just fill each OUTPUT buffer to the brim with > > the compressed bitstream. I.e., no need to split at frame or other boundaries. > > > > See section 4.5.1.7 in the spec. > > > > But I understand that various HW decoders *do* have limitations. I would really > > like to know about those, since that needs to be exposed to userspace somehow. > > AFAIK mtk-vcodec needs H.264 SPS and PPS to be split into their own > separate buffers. I believe it also needs 1 buffer to contain exactly > 1 frame and 1 frame to be fully contained inside 1 buffer. > > Venus also needed 1 buffer to contain exactly 1 frame and 1 frame to > be fully contained inside 1 buffer. It used to have some specific > requirements regarding SPS and PPS too, but I think that was fixed in > the firmware. > > > > > Specifically, the venus decoder needs to know the resolution of the coded video > > beforehand > > I don't think that's true for venus. It does parsing and can detect > the resolution. > > However that's probably the case for coda... Yes, it is currently true for the coda driver. But I believe it is not actually necessary for coda hardware / firmware. I have already started to split sequence initialization (where the firmare parses the bitstream headers) from internal frame buffer allocation (which have to match capture buffers in size), and I think it should be possible to completely decouple the two and postpone buffer allocation far enough to allow output stream start without prior knowledge of the resolution. The decoder coda firmware fully parses the bitstream, but the driver has to copy it from the external output buffers into an internal bitstream ringbuffer anyway, and a few workarounds are necessary to make it always succeed regardless of whether the first buffer presented to it only contains headers, headers and a very small frame, or enough data to completely fill the bitstream reader's prefetch buffer. For this the driver has to parse the NAL start headers to a certain degree. Due to this bitstream copy in the driver, in theory there are no limits on how the input data is split into v4l2 buffers, but in practice only single frame per v4l2 output buffer use cases are actually tested regularly. The encoder produces a single compressed frame per buffer. There is no support for B frames in the firmware, as far as I can tell. There is no driver support for interlaced formats currently, I'm not sure whether the firmware supports interlacing. regards Philipp
