Hi Chinmaya, Thanks for your patch. On Sun 30 Jun 2019 at 04:49, Chinmaya Krishnan Mahesh wrote: > This patch fixes the checkpatch.pl warning: > > WARNING: break is not useful after a goto or return but this is already fixed in the media subsystem tree, by a patch from Fabio: 964fcacddf media: imx7-media-csi: Remove unneeded break It is better to use that tree as reference for media fixes, sometimes some are already fixed there. Nevertheless many thanks for the patch. --- Cheers, Rui > > Signed-off-by: Chinmaya Krishnan Mahesh <chinmaya.mahesh@xxxxxxxxxxx> > --- > drivers/staging/media/imx/imx7-media-csi.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/staging/media/imx/imx7-media-csi.c b/drivers/staging/media/imx/imx7-media-csi.c > index a708a0340eb1..c15acca1dc0d 100644 > --- a/drivers/staging/media/imx/imx7-media-csi.c > +++ b/drivers/staging/media/imx/imx7-media-csi.c > @@ -1021,7 +1021,6 @@ static int imx7_csi_try_fmt(struct imx7_csi *csi, > break; > default: > return -EINVAL; > - break; > } > return 0; > }
