On Wed, Jun 26, 2019 at 11:52:16AM +0200, Hans Verkuil wrote:
> This driver set the colorspace to SRGB, but that makes no sense for
> a touchscreen. Use RAW instead. This also ensures consistency with the
> v4l_pix_format_touch() call that's used in v4l2-ioctl.c.
>
> Signed-off-by: Hans Verkuil <hverkuil-cisco@xxxxxxxxx>
> ---
> Dmitry, do you want to take this, or shall I? I have no preference.
Please take it.
Acked-by: Dmitry Torokhov <dmitry.torokhov@xxxxxxxxx>
> ---
> diff --git a/drivers/input/touchscreen/sur40.c b/drivers/input/touchscreen/sur40.c
> index 00cb1ba2d364..3fd3e862269b 100644
> --- a/drivers/input/touchscreen/sur40.c
> +++ b/drivers/input/touchscreen/sur40.c
> @@ -186,7 +186,7 @@ static const struct v4l2_pix_format sur40_pix_format[] = {
> .width = SENSOR_RES_X / 2,
> .height = SENSOR_RES_Y / 2,
> .field = V4L2_FIELD_NONE,
> - .colorspace = V4L2_COLORSPACE_SRGB,
> + .colorspace = V4L2_COLORSPACE_RAW,
> .bytesperline = SENSOR_RES_X / 2,
> .sizeimage = (SENSOR_RES_X/2) * (SENSOR_RES_Y/2),
> },
> @@ -195,7 +195,7 @@ static const struct v4l2_pix_format sur40_pix_format[] = {
> .width = SENSOR_RES_X / 2,
> .height = SENSOR_RES_Y / 2,
> .field = V4L2_FIELD_NONE,
> - .colorspace = V4L2_COLORSPACE_SRGB,
> + .colorspace = V4L2_COLORSPACE_RAW,
> .bytesperline = SENSOR_RES_X / 2,
> .sizeimage = (SENSOR_RES_X/2) * (SENSOR_RES_Y/2),
> }
--
Dmitry
