Hi Fabio, On Wed, Jun 26, 2019 at 08:56:13PM -0300, Fabio Estevam wrote: > There is no need to call regulator_set_voltage() for each regulator > that powers the camera. > > The voltage value for each regulator should be retrieved from the > device tree, so remove the unneeded regulator_set_voltage(). > > Signed-off-by: Fabio Estevam <festevam@xxxxxxxxx> Thanks for the patchset. I wonder if there are chances of this breaking something as the driver did not depend on the voltage being set correctly in DT. But we don't seem to have any users in DT source shipped with the kernel. So I guess I'll merge these at least if no-one complains (see the comment on the 2nd patch, too). No other sensor (I²C) driver appears to be touching the regulator voltage either. -- Regards, Sakari Ailus
