On Wed, 2019-06-26 at 11:48 +0200, Hans Verkuil wrote: > The function v4l_pix_format_touch() is called for S_FMT to set > v4l2_pix_format fields to default values for a v4l-touch device, > but it wasn't called for TRY_FMT. Add this. > > Signed-off-by: Hans Verkuil <hverkuil-cisco@xxxxxxxxx> > --- > diff --git a/drivers/media/v4l2-core/v4l2-ioctl.c b/drivers/media/v4l2-core/v4l2-ioctl.c > index b1f4b991dba6..c5c8c8ab7cf6 100644 > --- a/drivers/media/v4l2-core/v4l2-ioctl.c > +++ b/drivers/media/v4l2-core/v4l2-ioctl.c > @@ -1661,6 +1661,8 @@ static int v4l_try_fmt(const struct v4l2_ioctl_ops *ops, > ret = ops->vidioc_try_fmt_vid_cap(file, fh, arg); > /* just in case the driver zeroed it again */ > p->fmt.pix.priv = V4L2_PIX_FMT_PRIV_MAGIC; > + if (vfd->vfl_type == VFL_TYPE_TOUCH) > + v4l_pix_format_touch(&p->fmt.pix); Reviewed-by: Philipp Zabel <p.zabel@xxxxxxxxxxxxxx> regards Philipp