On 6/26/19 10:19 AM, Greg Kroah-Hartman wrote: > On Wed, Jun 26, 2019 at 09:52:49AM +0200, Hans Verkuil wrote: >> Instead of filling in the struct v4l2_capability device_caps >> field, fill in the struct video_device device_caps field. >> >> That way the V4L2 core knows what the capabilities of the >> video device are. >> >> Signed-off-by: Hans Verkuil <hverkuil-cisco@xxxxxxxxx> >> --- >> Hi Andrey, >> >> I noticed this new staging V4L2 driver. FYI, please CC any future patches to >> this driver to the linux-media@xxxxxxxxxxxxxxx mailinglist as well so we can >> review it. I'll post a review of this driver later today as well. In the >> meantime, I'd like to get this patch in since during the upcoming 5.4 cycle >> we will require that the device_caps field of struct video_device is set >> correctly. >> >> Greg, do you want to take this patch? After Andrey Acks it, of course. > > Yes, I will be glad to take it. I'll post a v2 in a minute :-) While reviewing the driver I found another issue in this code. Regards, Hans > > thanks, > > greg k-h >