On 6/25/19 6:41 PM, JP wrote:
On 6/25/19 1:16 PM, Sean Young wrote:
On Sun, Jun 16, 2019 at 02:39:29AM +0200, Jan Pieter van Woerkom wrote:
From: Jan Pieter van Woerkom <jp@xxxxxxx>
Adds support for the "Mygica T230C v2" into the "dvbsky" driver.
A small enhancement is also needed in the si2168 demodulator
driver, and a USB device ID in dvb-usb-ids.h .
This is v3.3 of the proposed patch, based on feedback from Sean
Young and Antti Palosaari.
Tested by patch author on a T230C v2.
Tested by Frank Rysanek on a T230C v2: can tune into locally
available DVB-T and DVB-T2 muxes, video and audio playback works.
Applies cleanly against Linux 5.1.10 .
The T230C v2 hardware needs a mode of the si2168 chip to be
set for which the si2168 driver previously had no support.
This patch uses a specific measure to configure this on the
T230C v2 hardware only - see the flag passed via the ts_mode
attribute and its dependency on USB_PID_MYGICA_T230C2. Other
devices using the si2168 demodulator driver are not affected
in any way.
Signed-off-by: Jan Pieter van Woerkom <jp@xxxxxxx>
Tested-by: Frank Rysanek <Frantisek.Rysanek@xxxxxxx>
---
diff -ru a/drivers/media/dvb-frontends/si2168.c
b/drivers/media/dvb-frontends/si2168.c
--- a/drivers/media/dvb-frontends/si2168.c 2019-06-04
07:59:45.000000000 +0200
+++ b/drivers/media/dvb-frontends/si2168.c 2019-06-08
19:47:32.385526558 +0200
@@ -91,8 +91,18 @@
dev_dbg(&client->dev, "%s acquire: %d\n", __func__, acquire);
+ /* set manual value */
+ if (dev->ts_mode | SI2168_TS_CLK_MANUAL) {
This looks wrong. Should it not be "dev->ts_mode & SI2168_TS_CLK_MANUAL"?
Now the expression is always true.
You're absolutely right. Silly me.
What now? Correct and repost?
yes, and next indentation looks also wrong
+ memcpy(cmd.args, "\x14\x00\x0d\x10\xe8\x03", 6);
+ cmd.wlen = 6;
+ cmd.rlen = 4;
+ ret = si2168_cmd_execute(client, &cmd);
+ if (ret)
+ return ret;
+ }
/* set TS_MODE property */
- memcpy(cmd.args, "\x14\x00\x01\x10\x10\x00", 6);
+ memcpy(cmd.args, "\x14\x00\x01\x10\x00\x00", 6);
+ cmd.args[4] = dev->ts_mode &
(SI2168_TS_CLK_AUTO|SI2168_TS_CLK_MANUAL);
if (acquire)
cmd.args[4] |= dev->ts_mode;
else
diff -ru a/drivers/media/dvb-frontends/si2168.h
b/drivers/media/dvb-frontends/si2168.h
--- a/drivers/media/dvb-frontends/si2168.h 2019-06-04
07:59:45.000000000 +0200
+++ b/drivers/media/dvb-frontends/si2168.h 2019-06-08
19:32:52.400320490 +0200
@@ -39,6 +39,8 @@
#define SI2168_TS_PARALLEL 0x06
#define SI2168_TS_SERIAL 0x03
#define SI2168_TS_TRISTATE 0x00
+#define SI2168_TS_CLK_AUTO 0x10
+#define SI2168_TS_CLK_MANUAL 0x20
u8 ts_mode;
/* TS clock inverted */
Thanks,
Sean
Thank you,
Jan Pieter.
regards
Antti
--
http://palosaari.fi/
