Hi Hans, I love your patch! Yet something to improve: [auto build test ERROR on linuxtv-media/master] [also build test ERROR on v5.2-rc6 next-20190621] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Hans-Verkuil/cec-improve-notifier-support-add-connector-info/20190625-043917 base: git://linuxtv.org/media_tree.git master config: x86_64-rhel-7.2 (attached as .config) compiler: clang version 9.0.0 (git://gitmirror/llvm_project fb2bd4a9398b35ee4f732ea0847d9c1226fc4cf3) reproduce: # save the attached .config to linux build tree make ARCH=x86_64 If you fix the issue, kindly add following tag Reported-by: kbuild test robot <lkp@xxxxxxxxx> All errors (new ones prefixed by >>): >> drivers/gpu//drm/i2c/tda998x_drv.c:1292:30: error: incompatible pointer types passing 'struct cec_connector_info *' to parameter of type 'const struct drm_connector *' [-Werror,-Wincompatible-pointer-types] cec_fill_conn_info_from_drm(&conn_info, connector); ^~~~~~~~~~ include/media/cec.h:381:57: note: passing argument to parameter 'connector' here cec_fill_conn_info_from_drm(const struct drm_connector *connector, ^ >> drivers/gpu//drm/i2c/tda998x_drv.c:1292:42: error: incompatible pointer types passing 'struct drm_connector *' to parameter of type 'struct cec_connector_info *' [-Werror,-Wincompatible-pointer-types] cec_fill_conn_info_from_drm(&conn_info, connector); ^~~~~~~~~ include/media/cec.h:382:35: note: passing argument to parameter 'conn_info' here struct cec_connector_info *conn_info) ^ 2 errors generated. vim +1292 drivers/gpu//drm/i2c/tda998x_drv.c 1251 1252 static int tda998x_connector_init(struct tda998x_priv *priv, 1253 struct drm_device *drm) 1254 { 1255 struct drm_connector *connector = &priv->connector; 1256 struct cec_connector_info conn_info; 1257 struct i2c_board_info cec_info; 1258 int ret; 1259 1260 connector->interlace_allowed = 1; 1261 1262 if (priv->hdmi->irq) 1263 connector->polled = DRM_CONNECTOR_POLL_HPD; 1264 else 1265 connector->polled = DRM_CONNECTOR_POLL_CONNECT | 1266 DRM_CONNECTOR_POLL_DISCONNECT; 1267 1268 drm_connector_helper_add(connector, &tda998x_connector_helper_funcs); 1269 ret = drm_connector_init(drm, connector, &tda998x_connector_funcs, 1270 DRM_MODE_CONNECTOR_HDMIA); 1271 if (ret) 1272 return ret; 1273 1274 /* 1275 * Some TDA998x are actually two I2C devices merged onto one piece 1276 * of silicon: TDA9989 and TDA19989 combine the HDMI transmitter 1277 * with a slightly modified TDA9950 CEC device. The CEC device 1278 * is at the TDA9950 address, with the address pins strapped across 1279 * to the TDA998x address pins. Hence, it always has the same 1280 * offset. 1281 */ 1282 memset(&cec_info, 0, sizeof(cec_info)); 1283 strlcpy(cec_info.type, "tda9950", sizeof(cec_info.type)); 1284 cec_info.addr = priv->cec_addr; 1285 cec_info.platform_data = &priv->cec_glue; 1286 cec_info.irq = priv->hdmi->irq; 1287 1288 priv->cec = i2c_new_device(priv->hdmi->adapter, &cec_info); 1289 if (!priv->cec) 1290 return -ENODEV; 1291 > 1292 cec_fill_conn_info_from_drm(&conn_info, connector); 1293 1294 priv->cec_notify = cec_notifier_conn_register(priv->cec_glue.parent, 1295 NULL, &conn_info); 1296 if (!priv->cec_notify) 1297 return -ENOMEM; 1298 1299 drm_connector_attach_encoder(&priv->connector, 1300 priv->bridge.encoder); 1301 1302 return 0; 1303 } 1304 --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation
Attachment:
.config.gz
Description: application/gzip
