Sakari Ailus <sakari.ailus@xxxxxx> writes: > On Thu, Jun 20, 2019 at 01:17:17PM +0300, Sakari Ailus wrote: >> diff --git a/drivers/media/i2c/mt9m111.c b/drivers/media/i2c/mt9m111.c >> index bd3a51c3b081..9761a6105407 100644 >> --- a/drivers/media/i2c/mt9m111.c >> +++ b/drivers/media/i2c/mt9m111.c >> @@ -1263,9 +1263,11 @@ static int mt9m111_probe(struct i2c_client *client, >> if (!mt9m111) >> return -ENOMEM; >> >> - ret = mt9m111_probe_fw(client, mt9m111); >> - if (ret) >> - return ret; >> + if (dev_fwnode(client->dev)) { > > &client->dev > >> + ret = mt9m111_probe_fw(client, mt9m111); >> + if (ret) >> + return ret; >> + } >> >> mt9m111->clk = v4l2_clk_get(&client->dev, "mclk"); >> if (IS_ERR(mt9m111->clk)) Sure, you can take the patch as yours, or sign off my modified patch, whatever pleases you. Cheers. -- Robert