Hi Ezequiel, I love your patch! Perhaps something to improve: [auto build test WARNING on linuxtv-media/master] [also build test WARNING on next-20190621] [cannot apply to v5.2-rc5] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Ezequiel-Garcia/media-hantro-Use-vb2_get_buffer/20190622-022557 base: git://linuxtv.org/media_tree.git master config: nds32-allmodconfig (attached as .config) compiler: nds32le-linux-gcc (GCC) 8.1.0 reproduce: wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # save the attached .config to linux build tree GCC_VERSION=8.1.0 make.cross ARCH=nds32 If you fix the issue, kindly add following tag Reported-by: kbuild test robot <lkp@xxxxxxxxx> All warnings (new ones prefixed by >>): drivers/staging/media/hantro/hantro_drv.c: In function 'hantro_get_ref': drivers/staging/media/hantro/hantro_drv.c:54:8: error: implicit declaration of function 'vb2_get_buffer'; did you mean 'vb2_expbuf'? [-Werror=implicit-function-declaration] buf = vb2_get_buffer(q, index); ^~~~~~~~~~~~~~ vb2_expbuf >> drivers/staging/media/hantro/hantro_drv.c:54:6: warning: assignment to 'struct vb2_buffer *' from 'int' makes pointer from integer without a cast [-Wint-conversion] buf = vb2_get_buffer(q, index); ^ cc1: some warnings being treated as errors vim +54 drivers/staging/media/hantro/hantro_drv.c 45 46 dma_addr_t hantro_get_ref(struct vb2_queue *q, u64 ts) 47 { 48 struct vb2_buffer *buf; 49 int index; 50 51 index = vb2_find_timestamp(q, ts, 0); 52 if (index < 0) 53 return 0; > 54 buf = vb2_get_buffer(q, index); 55 return vb2_dma_contig_plane_dma_addr(buf, 0); 56 } 57 --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation
Attachment:
.config.gz
Description: application/gzip