Hi Eugen, On Wed, Jun 19, 2019 at 07:24:41AM +0000, Eugen.Hristev@xxxxxxxxxxxxx wrote: > From: Eugen Hristev <eugen.hristev@xxxxxxxxxxxxx> > > ld: drivers/media/platform/atmel/atmel-isc-base.o:(.bss+0x0): multiple definition of `debug'; arch/x86/entry/entry_32.o:(.entry.text+0x21ac): first defined here > > Changed module parameters to static. > > Reported-by: kbuild test robot <lkp@xxxxxxxxx> > Signed-off-by: Eugen Hristev <eugen.hristev@xxxxxxxxxxxxx> > --- > > Hello Hans, > > Sorry for this, it looks like i386 has a stray weird 'debug' symbol which > causes an error. > I changed the module parameters of the atmel-isc to 'static' but now they > cannot be accessed in the other module files. > Will have to create a get function to be used in the other files if needed > later. Any other way to make a symbol static to current module and not > current file ? It would be useful for other config variables as well. > I was not sure if you want to squash this over the faulty patch or add it > as a separate patch. Please consider using dev_dbg() instead of a driver specific parameter for debug. For the patch: Acked-by: Sakari Ailus <sakari.ailus@xxxxxxxxxxxxxxx> -- Sakari Ailus
